Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Podio event source: Use new, exception-free Emit() callback #1624

Merged
merged 3 commits into from
Nov 22, 2024

Conversation

nathanwbrei
Copy link
Contributor

Briefly, what does this PR introduce?

Podio event source uses a new Emit() callback which doesn't use exceptions for control flow.

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: Refactoring

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No

Does this PR change default behavior?

No

@veprbl veprbl requested a review from wdconinc November 21, 2024 00:43
@veprbl veprbl enabled auto-merge November 21, 2024 23:03
@veprbl veprbl added this pull request to the merge queue Nov 22, 2024
Merged via the queue into main with commit 6eb0941 Nov 22, 2024
84 of 86 checks passed
@veprbl veprbl deleted the nbrei_eventsource branch November 22, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants